Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassOrdering identifies minimum set of reorders #3144

Closed
hbmartin opened this issue Oct 14, 2020 · 4 comments · Fixed by #6003
Closed

ClassOrdering identifies minimum set of reorders #3144

hbmartin opened this issue Oct 14, 2020 · 4 comments · Fixed by #6003
Assignees
@hbmartin
Labels
help wanted improvement rules

Comments

@hbmartin
Copy link
Contributor

Expected Behavior

ClassOrdering should report the minimum work to properly order a class.

Current Behavior

As of #3142 ClassOrdering reports a list of all misordered pairs. @BraisGabin pointed out that this could result in over-reporting issues in a class #3142 (comment)

Context

Addressing this issue will enable user to more quickly identify and fix misorders.
@hbmartin hbmartin mentioned this issue Oct 14, 2020
Merged
@BraisGabin
Copy link
Member

Why is this closed? The feature described here is not implemented yet.

@arturbosch arturbosch reopened this Oct 21, 2020
@arturbosch
Copy link
Member

arturbosch commented Oct 21, 2020 •
edited
Loading

Why is this closed? The feature described here is not implemented yet.

Sorry, misread/misinterpreted the PR :)

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 8, 2021
@atulgpt atulgpt mentioned this issue Apr 15, 2023
Merged
@atulgpt
Copy link
Contributor

atulgpt commented Apr 16, 2023

Hi @arturbosch / @BraisGabin raised the PR at #6003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hbmartin hbmartin

Labels
help wanted improvement rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix redundant ClassOrdering violations using maximum increasing section atulgpt/detekt
5 participants
@BraisGabin @hbmartin @atulgpt @arturbosch @schalkms