ClassOrdering rule reports a list of errors

[hbmartin]

• Addresses ClassOrdering only reports first misorder, not all misorders #3141 where only the first misorder in a class is reported
• Also report entity where error occurred, not just parent class
• Both of these changes might break existing baselines? - not sure how to address this
• Follow up to ClassOrdering reports a message describing the misorder #3138

[codecov]

Codecov Report

Merging #3142 into master will increase coverage by 0.05%.
The diff coverage is 87.09%.

@@             Coverage Diff              @@
##             master    #3142      +/-   ##
============================================
+ Coverage     79.46%   79.52%   +0.05%     
- Complexity     2591     2592       +1     
============================================
  Files           437      437              
  Lines          7830     7852      +22     
  Branches       1490     1495       +5     
============================================
+ Hits           6222     6244      +22     
+ Misses          819      817       -2     
- Partials        789      791       +2     

Impacted Files	Coverage Δ	Complexity Δ
...turbosch/detekt/rules/style/UnusedPrivateMember.kt	90.62% <78.94%> (+0.35%)	5.00 <0.00> (ø)
...lab/arturbosch/detekt/rules/style/ClassOrdering.kt	91.89% <100.00%> (+1.89%)	4.00 <0.00> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt	100.00% <0.00%> (+6.66%)	15.00% <0.00%> (+1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4722c26...be32c31. Read the comment docs.

[schalkms]

Thanks for addressing this issue and further improving this rule!
Please see my attached comments in regards to two minor improvements.

[schalkms]

Good one!

[BraisGabin]

I'm not sure if this is the best way to report all the errors. I mean, we can be reporting more than the actual movements that you need to do. This is the same problem as find the minimum insertions to sort an array (related links)

I'm not against merging this because it's better than the current implementation but I think that we should keep an issue to track this and implement it to report the proper number of issues.

[hbmartin]

@BraisGabin made an issue to track your comment: #3144 , please assign to me 😃