New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement #1055 MagicNumber #1061

Merged

arturbosch merged 1 commit into detekt:master from schalkms:improvement-#1055-MagicNumber

Aug 31, 2018

Member

schalkms commented Aug 21, 2018

reference #1055
@vanniktech


          Implements MagicNumber for default params in functions

62a8bd0

# reference #1055

vanniktech approved these changes

View reviewed changes

detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/MagicNumberSpec.kt Outdated

@@ @@ -629,22 +629,22 @@ class MagicNumberSpec : Spek({ @@
               	given("functions with and without braces which return values") {
-              		it("does not report functions that always returns a constant value") {
+              		it("does not report functions that always return a constant value") {

Contributor

vanniktech Aug 21, 2018

It was correct before

arturbosch merged commit 25b6f9f into detekt:master

schalkms deleted the improvement-#1055-MagicNumber branch

September 3, 2018 18:31

arturbosch added this to the RC9 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet