New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor KotlinCoreEnvironment test setup #1880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an extension function to `Root` to automatically create and dispose the KotlinCoreEnvironment for testing purposes. The objects in the KotlinCoreEnvironment are wrapped to simplify the object creation and disposal.
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
============================================
- Coverage 80.3% 80.25% -0.06%
+ Complexity 1958 1949 -9
============================================
Files 325 325
Lines 5519 5504 -15
Branches 1026 1019 -7
============================================
- Hits 4432 4417 -15
Misses 557 557
Partials 530 530
Continue to review full report at Codecov.
|
This was referenced Aug 31, 2019
arturbosch
reviewed
Sep 6, 2019
detekt-test/src/main/kotlin/io/gitlab/arturbosch/detekt/test/KtTestCompiler.kt
Outdated
Show resolved
Hide resolved
This was referenced Sep 7, 2019
arturbosch
approved these changes
Sep 12, 2019
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Refactor KotlinCoreEnvironment test setup This PR adds an extension function to `Root` to automatically create and dispose the KotlinCoreEnvironment for testing purposes. The objects in the KotlinCoreEnvironment are wrapped to simplify the object creation and disposal. * Inline KotlinCoreEnvironment test creation * Refactor KotlinCoreEnvironmentWrapper environment
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Refactor KotlinCoreEnvironment test setup This PR adds an extension function to `Root` to automatically create and dispose the KotlinCoreEnvironment for testing purposes. The objects in the KotlinCoreEnvironment are wrapped to simplify the object creation and disposal. * Inline KotlinCoreEnvironment test creation * Refactor KotlinCoreEnvironmentWrapper environment
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Refactor KotlinCoreEnvironment test setup This PR adds an extension function to `Root` to automatically create and dispose the KotlinCoreEnvironment for testing purposes. The objects in the KotlinCoreEnvironment are wrapped to simplify the object creation and disposal. * Inline KotlinCoreEnvironment test creation * Refactor KotlinCoreEnvironmentWrapper environment
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Refactor KotlinCoreEnvironment test setup This PR adds an extension function to `Root` to automatically create and dispose the KotlinCoreEnvironment for testing purposes. The objects in the KotlinCoreEnvironment are wrapped to simplify the object creation and disposal. * Inline KotlinCoreEnvironment test creation * Refactor KotlinCoreEnvironmentWrapper environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extension function to
Root
to automatically create anddispose the KotlinCoreEnvironment for testing purposes.
The objects in the KotlinCoreEnvironment are wrapped to simplify the
object creation and disposal.