Improve UnusedPrivateMember when it's related with parameters #1949
Conversation
There was a problem hiding this comment.
Excuse me for reporting back after such a long timeframe.
I suppose that the problem here lies in the following referenced lines.
Note that I didn't debug the test code.
Only a single parameter named unusedParameter gets added to the Map.
Therefore, only 1 parameter gets reported.
I hope that this serves as a good starting point for you. If not, please don't hesitate to ask for help.
BraisGabin
force-pushed
the
unused-private-member
branch
from
387f95e
to
32d0701
Compare
BraisGabin
changed the title
|
Reading the code I found that the functions has the same problem but it's far more complicated to check. I'm going to create an issue to talk about that. So this PR is only to check the parameters. |
| val code = """ | ||
| class Test { | ||
| val value = usedMethod(1) | ||
| val value2 = usedMethod2(1) | ||
|
|
||
| private fun usedMethod(unusedParameter: Int): Int { | ||
| return 5 | ||
| } | ||
|
|
||
| private fun usedMethod2(unusedParameter: Int) { | ||
| return 5 | ||
| } | ||
| } | ||
| """ |
There was a problem hiding this comment.
nit: 4 missing spaces (indentation)
Please elaborate on that in a separate issue, so that the community can also understand this problem. |
If two parameters are called the same in different calls now it's detected as two warnings.
BraisGabin
force-pushed
the
unused-private-member
branch
from
32d0701
to
febc839
Compare
|
Fixed. Yes, this is ready to merge and I'll write the issue. |
If two parameters are called the same in different calls now it's detected as two warnings.
If two parameters are called the same in different calls now it's detected as two warnings.
If two parameters are called the same in two different functions and both are not used now we report them as two errors.