Fix exception when running ArrayPrimitive on star-projected arrays #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
reviewed
Dec 16, 2019
| @@ -73,6 +78,11 @@ class ArrayPrimitiveSpec : Spek({ | |||
| assertThat(subject.compileAndLint(code)).isEmpty() | |||
| } | |||
|
|
|||
| it("is a star-projected array") { | |||
| val code = "fun returningFunction(): Array<*> { return emptyArray() }" | |||
There was a problem hiding this comment.
This snippet is not a valid Kotlin code.
We have an additional CI check that verifies, whether the test code is valid.
io.gitlab.arturbosch.detekt.test.KotlinScriptException: Given Kotlin code is invalid.
Caused by: javax.script.ScriptException: Error: error: type inference failed: Not enough information to infer parameter T in inline fun <reified T> emptyArray(): Array<T>
Please specify it explicitly.
fun returningFunction(): Array<*> { return emptyArray() }
There was a problem hiding this comment.
That's very cool! Fixed it with emptyArray<Any>().
Codecov Report
@@ Coverage Diff @@
## master #2181 +/- ##
=========================================
Coverage 80.59% 80.59%
- Complexity 2028 2029 +1
=========================================
Files 338 338
Lines 5850 5850
Branches 1066 1066
=========================================
Hits 4715 4715
Misses 564 564
Partials 571 571
Continue to review full report at Codecov.
|
schalkms
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2176