Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BuildFailure code #2250

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Refactor BuildFailure code #2250

merged 2 commits into from
Jan 12, 2020

Conversation

schalkms
Copy link
Member

  • Refactor BuildFailure items into corresponding kt file
  • Add tests for IssueExtension

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #2250 into master will increase coverage by 0.04%.
The diff coverage is 93.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2250      +/-   ##
============================================
+ Coverage      81.4%   81.44%   +0.04%     
- Complexity     2077     2081       +4     
============================================
  Files           343      346       +3     
  Lines          5985     5993       +8     
  Branches       1086     1086              
============================================
+ Hits           4872     4881       +9     
  Misses          532      532              
+ Partials        581      580       -1
Impacted Files Coverage Δ Complexity Δ
...in/io/gitlab/arturbosch/detekt/cli/BuildFailure.kt 100% <ø> (+9.37%) 1 <0> (ø) ⬇️
.../io/gitlab/arturbosch/detekt/cli/IssueExtension.kt 93.54% <93.54%> (ø) 0 <0> (?)
...rmatting/wrappers/NoEmptyFirstLineInMethodBlock.kt 100% <0%> (ø) 2% <0%> (?)
...ch/detekt/formatting/wrappers/EnumEntryNameCase.kt 100% <0%> (ø) 2% <0%> (?)
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt 87.75% <0%> (+0.52%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2486bfa...5507af3. Read the comment docs.

@arturbosch arturbosch merged commit 47eb56f into detekt:master Jan 12, 2020
@arturbosch arturbosch added this to the 1.4.0 milestone Jan 12, 2020
@schalkms schalkms deleted the IssueExtension branch January 12, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants