Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always dispose Kotlin environment fixing memory leak in error cases #2276

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.5.0 milestone Jan 19, 2020
@arturbosch arturbosch force-pushed the fix-memory-leak-on-errors branch from 10d9189 to d34bba2 Compare January 19, 2020 13:28
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #2276 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2276   +/-   ##
=========================================
  Coverage     81.65%   81.65%           
+ Complexity     2110     2109    -1     
=========================================
  Files           348      348           
  Lines          6033     6033           
  Branches       1105     1105           
=========================================
  Hits           4926     4926           
  Misses          518      518           
  Partials        589      589
Impacted Files Coverage Δ Complexity Δ
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 87.5% <ø> (-0.22%) 15 <0> (ø)
...itlab/arturbosch/detekt/core/ProcessingSettings.kt 90% <100%> (+0.16%) 18 <0> (-1) ⬇️
.../arturbosch/detekt/cli/runners/SingleRuleRunner.kt 86.11% <100%> (ø) 6 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e5fc4...d34bba2. Read the comment docs.

@arturbosch arturbosch merged commit cfbaabf into master Jan 19, 2020
@arturbosch arturbosch deleted the fix-memory-leak-on-errors branch January 19, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants