Added rule for safe cast instead of if-else-null #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Will check it out tomorror. Thank you very much! |
|
Maybe also add a test case for a negative case? |
arturbosch
reviewed
Jul 23, 2017
| import io.gitlab.arturbosch.detekt.rules.style.NamingConventionViolation | ||
| import io.gitlab.arturbosch.detekt.rules.style.NewLineAtEndOfFile | ||
| import io.gitlab.arturbosch.detekt.rules.style.WildcardImport | ||
| import io.gitlab.arturbosch.detekt.rules.style.* |
There was a problem hiding this comment.
Pls import the code-style.xml when working on detekt. The codebase should not have wildcards.
|
|
||
| @Test | ||
| fun findNegated() { | ||
| val code = "fun test() {\n" + |
There was a problem hiding this comment.
Use multiline strings in your test cases. It's better to read :)
| } | ||
|
|
||
| private fun retrieveFindings(code: String): List<Finding> { | ||
| return SafeCast().lint(code) |
There was a problem hiding this comment.
Extend RuleTest and override the field rule with SafeCast. rule.lint(code) can then be inlined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#197 feature