Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove idea integration #2706

Merged
merged 3 commits into from
May 18, 2020
Merged

Remove idea integration #2706

merged 3 commits into from
May 18, 2020

Conversation

arturbosch
Copy link
Member

Continuation from #2704

Task wrapper over inspect.sh hangs for some hours and wrapper task over format.sh crashes with "container already disposed" messages
@arturbosch arturbosch added this to the 1.10.0 milestone May 18, 2020
@arturbosch arturbosch added the migration Marker to add a migration step in the changelog label May 18, 2020
@github-actions
Copy link

Fails
🚫

danger-kotlin failed.

Log

Executing kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json - pid 375
Uncaught Kotlin exception: kotlin.Exception: Command kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json exited with code 768
        at kfun:systems.danger.cmd.Cmd.exec() (0x21c739)
        at kfun:systems.danger.cmd.dangerfile.DangerFile.execute(kotlin.String;kotlin.String) (0x21d227)
        at kfun:systems.danger.DangerKotlin.run() (0x21c0e6)
        at Init_and_run_start (0x21f472)
        at __libc_start_main (0x7f241d6d4b97)
        at  (0x20f029)
        at  ((nil))

Generated by 🚫 dangerJS against 3be5b53

@github-actions
Copy link

Fails
🚫

danger-kotlin failed.

Log

Executing kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json - pid 376
Uncaught Kotlin exception: kotlin.Exception: Command kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json exited with code 768
        at kfun:systems.danger.cmd.Cmd.exec() (0x21c739)
        at kfun:systems.danger.cmd.dangerfile.DangerFile.execute(kotlin.String;kotlin.String) (0x21d227)
        at kfun:systems.danger.DangerKotlin.run() (0x21c0e6)
        at Init_and_run_start (0x21f472)
        at __libc_start_main (0x7f4775277b97)
        at  (0x20f029)
        at  ((nil))

Generated by 🚫 dangerJS against 3be5b53

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #2706 into master will increase coverage by 0.57%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2706      +/-   ##
============================================
+ Coverage     79.85%   80.43%   +0.57%     
+ Complexity     2305     2303       -2     
============================================
  Files           381      377       -4     
  Lines          6940     6883      -57     
  Branches       1250     1244       -6     
============================================
- Hits           5542     5536       -6     
+ Misses          779      728      -51     
  Partials        619      619              
Impacted Files Coverage Δ Complexity Δ
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 55.68% <ø> (+3.15%) 10.00 <0.00> (-1.00) ⬆️
...ab/arturbosch/detekt/extensions/DetektExtension.kt 25.00% <ø> (-2.78%) 2.00 <0.00> (ø)
...o/gitlab/arturbosch/detekt/invoke/DetektInvoker.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec2d5a...3be5b53. Read the comment docs.

@BraisGabin
Copy link
Member

@Mkohm this seems kind of noisy. If danger fails we don't need a comment in the PR showing the error. Is it possible to just report the code smells?

@arturbosch arturbosch merged commit c0d97cc into master May 18, 2020
@arturbosch arturbosch deleted the remove-idea-integration branch May 18, 2020 18:45
@cortinico cortinico mentioned this pull request Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Marker to add a migration step in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants