-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove idea integration #2706
Remove idea integration #2706
Conversation
Task wrapper over inspect.sh hangs for some hours and wrapper task over format.sh crashes with "container already disposed" messages
LogExecuting kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json - pid 375
Uncaught Kotlin exception: kotlin.Exception: Command kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json exited with code 768
at kfun:systems.danger.cmd.Cmd.exec() (0x21c739)
at kfun:systems.danger.cmd.dangerfile.DangerFile.execute(kotlin.String;kotlin.String) (0x21d227)
at kfun:systems.danger.DangerKotlin.run() (0x21c0e6)
at Init_and_run_start (0x21f472)
at __libc_start_main (0x7f241d6d4b97)
at (0x20f029)
at ((nil))
|
LogExecuting kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json - pid 376
Uncaught Kotlin exception: kotlin.Exception: Command kotlinc -script-templates systems.danger.kts.DangerFileScript -cp /usr/local/lib/danger/danger-kotlin.jar -script /Dangerfile.df.kts /tmp/danger-dsl.json danger_out.json exited with code 768
at kfun:systems.danger.cmd.Cmd.exec() (0x21c739)
at kfun:systems.danger.cmd.dangerfile.DangerFile.execute(kotlin.String;kotlin.String) (0x21d227)
at kfun:systems.danger.DangerKotlin.run() (0x21c0e6)
at Init_and_run_start (0x21f472)
at __libc_start_main (0x7f4775277b97)
at (0x20f029)
at ((nil))
|
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
============================================
+ Coverage 79.85% 80.43% +0.57%
+ Complexity 2305 2303 -2
============================================
Files 381 377 -4
Lines 6940 6883 -57
Branches 1250 1244 -6
============================================
- Hits 5542 5536 -6
+ Misses 779 728 -51
Partials 619 619
Continue to review full report at Codecov.
|
@Mkohm this seems kind of noisy. If danger fails we don't need a comment in the PR showing the error. Is it possible to just report the code smells? |
Continuation from #2704