Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back to non snapshot spek version #2922

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Aug 2, 2020

Waiting for a new release - #2902

@arturbosch arturbosch changed the title Update from snapshot spek version Roll back to non snapshot spek version Aug 20, 2020
@arturbosch
Copy link
Member Author

I've rolled back to 2.0.12 of Spek to fix #2976 .
Build should be 10-20 seconds slower now.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2922 into master will decrease coverage by 0.54%.
The diff coverage is 84.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2922      +/-   ##
============================================
- Coverage     80.31%   79.77%   -0.55%     
- Complexity     2477     2493      +16     
============================================
  Files           424      424              
  Lines          7478     7490      +12     
  Branches       1369     1409      +40     
============================================
- Hits           6006     5975      -31     
- Misses          760      768       +8     
- Partials        712      747      +35     
Impacted Files Coverage Δ Complexity Δ
...io/gitlab/arturbosch/detekt/core/BindingContext.kt 6.25% <0.00%> (+0.36%) 0.00 <0.00> (ø)
...ab/arturbosch/detekt/core/settings/LoggingAware.kt 42.85% <50.00%> (ø) 0.00 <0.00> (ø)
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 91.42% <86.66%> (+0.16%) 5.00 <0.00> (ø)
...ab/arturbosch/detekt/cli/DetektProgressListener.kt 83.33% <100.00%> (ø) 4.00 <0.00> (ø)
...tlin/io/gitlab/arturbosch/detekt/cli/JCommander.kt 91.30% <100.00%> (ø) 0.00 <0.00> (ø)
...gitlab/arturbosch/detekt/cli/runners/AstPrinter.kt 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...ab/arturbosch/detekt/cli/runners/ConfigExporter.kt 75.00% <100.00%> (ø) 2.00 <0.00> (ø)
...ab/arturbosch/detekt/cli/runners/ElementPrinter.kt 96.42% <100.00%> (ø) 11.00 <0.00> (ø)
...ab/arturbosch/detekt/cli/runners/VersionPrinter.kt 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...b/arturbosch/detekt/core/reporting/OutputFacade.kt 94.11% <100.00%> (ø) 10.00 <0.00> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee49144...7279b6f. Read the comment docs.

@arturbosch arturbosch merged commit 11181a2 into master Aug 20, 2020
@arturbosch arturbosch deleted the remove-spek-snapshot branch August 20, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants