Run Gradle Android tests conditionally when sdk path is defined#3014
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3014 +/- ##
=========================================
Coverage 79.53% 79.53%
Complexity 2532 2532
=========================================
Files 431 431
Lines 7637 7637
Branches 1447 1447
=========================================
Hits 6074 6074
Misses 795 795
Partials 768 768 Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Aug 25, 2020
| describe("detekt plugin - Android") { | ||
| describe( | ||
| "detekt plugin - Android", | ||
| skip = if (System.getenv("ANDROID_SDK_ROOT") != null) Skip.No else Skip.Yes("No android sdk.") |
Member
There was a problem hiding this comment.
I was going to say that "normal" environment is ANDROID_HOME but I just found that they deprecated that environment. A thing that I learned today. And a thing that I need to change in all my environments too...
Member
Author
There was a problem hiding this comment.
It's the one got reported when the build crashed for me locally xD.
One day I will code some Android too 8-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2787