Simplify reporting message for IgnoredReturnValue#3068
Merged
cortinico merged 1 commit intodetekt:masterfrom Sep 14, 2020
Merged
Simplify reporting message for IgnoredReturnValue#3068cortinico merged 1 commit intodetekt:masterfrom
cortinico merged 1 commit intodetekt:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3068 +/- ##
============================================
- Coverage 79.27% 79.26% -0.02%
Complexity 2563 2563
============================================
Files 432 432
Lines 7725 7726 +1
Branches 1468 1469 +1
============================================
Hits 6124 6124
Misses 816 816
- Partials 785 786 +1
Continue to review full report at Codecov.
|
schalkms
approved these changes
Sep 13, 2020
arturbosch
approved these changes
Sep 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the error message for
IgnoredReturnValueto report only the name of the caller that is affected by the finding. I also added ahasMessagemethod to ourFindingAssertas we happen to have several scenarios where we want to asset the message in the codebase.Fixes #3052