Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify reporting message for IgnoredReturnValue #3068

Merged

Conversation

cortinico
Copy link
Member

Simplifies the error message for IgnoredReturnValue to report only the name of the caller that is affected by the finding. I also added a hasMessage method to our FindingAssert as we happen to have several scenarios where we want to asset the message in the codebase.

Fixes #3052

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #3068 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3068      +/-   ##
============================================
- Coverage     79.27%   79.26%   -0.02%     
  Complexity     2563     2563              
============================================
  Files           432      432              
  Lines          7725     7726       +1     
  Branches       1468     1469       +1     
============================================
  Hits           6124     6124              
  Misses          816      816              
- Partials        785      786       +1     
Impacted Files Coverage Δ Complexity Δ
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 75.51% <50.00%> (-1.58%) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f2e8e...4676a51. Read the comment docs.

@arturbosch arturbosch added this to the 1.14.0 milestone Sep 13, 2020
@cortinico cortinico merged commit 1c6a7ea into detekt:master Sep 14, 2020
@cortinico cortinico deleted the nc/3052/IgnoredReturnValue-simplify-message branch September 14, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgnoredReturnValue should only report name of method/function called
3 participants