Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce --all-rules flag #3253

Merged
merged 5 commits into from
Jan 18, 2021
Merged

Introduce --all-rules flag #3253

merged 5 commits into from
Jan 18, 2021

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Nov 28, 2020

Part one to replace and deprecate --fail-fast in the long run - #2267

@BraisGabin @cortinico I accidentally merged #3247 and needed to revert it. So this is the same as #3247.
Now really for 1.16.0.

@arturbosch arturbosch added this to the 1.16.0 milestone Nov 28, 2020
@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #3253 (2eb05f7) into master (f9e3e41) will increase coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3253      +/-   ##
============================================
+ Coverage     80.43%   80.45%   +0.02%     
+ Complexity     2740     2739       -1     
============================================
  Files           448      448              
  Lines          8281     8280       -1     
  Branches       1573     1572       -1     
============================================
+ Hits           6661     6662       +1     
+ Misses          772      771       -1     
+ Partials        848      847       -1     
Impacted Files Coverage Δ Complexity Δ
...lin/io/github/detekt/tooling/api/spec/RulesSpec.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 81.08% <50.00%> (ø) 9.00 <0.00> (ø)
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 80.43% <100.00%> (ø) 0.00 <0.00> (ø)
...ab/arturbosch/detekt/core/config/AllRulesConfig.kt 44.44% <100.00%> (ø) 4.00 <2.00> (?)
...n/io/github/detekt/tooling/dsl/RulesSpecBuilder.kt 94.73% <100.00%> (ø) 7.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e3e41...b0819e5. Read the comment docs.

@chao2zhang
Copy link
Member

I got confused when reading the code and documentation around failFast as they are at odds. Thank you for publishing this to wipe off such confusion!

@arturbosch arturbosch merged commit 221d7a3 into master Jan 18, 2021
@arturbosch arturbosch deleted the new-cli-flags branch January 18, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants