Magic number extension functions #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
maginc-number-extension-functions
branch
from
37a878d
to
0953366
Compare
Codecov Report
@@ Coverage Diff @@
## master #3299 +/- ##
============================================
- Coverage 80.33% 80.32% -0.01%
- Complexity 2719 2721 +2
============================================
Files 445 445
Lines 8165 8168 +3
Branches 1552 1553 +1
============================================
+ Hits 6559 6561 +2
Misses 774 774
- Partials 832 833 +1
Continue to review full report at Codecov.
|
schalkms
approved these changes
Dec 19, 2020
BraisGabin
force-pushed
the
maginc-number-extension-functions
branch
from
0953366
to
0eaa99e
Compare
|
I changed the PR a bit: I enabled |
chao2zhang
pushed a commit
to chao2zhang/detekt
that referenced
this pull request
Dec 27, 2020
* Use braces in multiline ifs * Introduce ignoreExtensionFunctions in MagicNumber * Enable ignoreExtensionFunctions by default
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Use braces in multiline ifs * Introduce ignoreExtensionFunctions in MagicNumber * Enable ignoreExtensionFunctions by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow things like:
Because they are not magic numbers, they have units.
More about this in #3283
This PR adds a new flag to MagicNumber to allow this. Open questions:
ignoreExtensionFunctionsa good name?