Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XmlOutputFormatSpec #3325

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Refactor XmlOutputFormatSpec #3325

merged 1 commit into from
Dec 27, 2020

Conversation

chao2zhang
Copy link
Member

Test content is crowded into a single line, making it difficult to read and update.

@chao2zhang chao2zhang mentioned this pull request Dec 26, 2020
Merged
Refactor XmlOutputFormatSpec
08e0ead 
Test content is crowded into a single line, making it difficult to read and update.
@codecov
Copy link

codecov bot commented Dec 26, 2020 •
edited

Codecov Report

Merging #3325 (08e0ead) into master (0d6ac64) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3325   +/-   ##
=========================================
  Coverage     80.33%   80.33%           
  Complexity     2719     2719           
=========================================
  Files           445      445           
  Lines          8165     8165           
  Branches       1552     1552           
=========================================
  Hits           6559     6559           
  Misses          774      774           
  Partials        832      832

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6ac64...08e0ead. Read the comment docs.

BraisGabin
BraisGabin approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There was not need to do this in this case. It was just a suggestion for future PRs. But I really appreciate it :)

@BraisGabin BraisGabin merged commit a9c4e93 into detekt:master Dec 27, 2020
@chao2zhang chao2zhang deleted the xmltest branch December 28, 2020 23:03
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
@arturbosch
Refactor XmlOutputFormatSpec (#3325)
29212ed 
Test content is crowded into a single line, making it difficult to read and update.
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chao2zhang @BraisGabin @arturbosch