Refactor integration test for detekt-gradle-plugin#3356
Merged
schalkms merged 1 commit intodetekt:masterfrom Jan 8, 2021
Merged
Refactor integration test for detekt-gradle-plugin#3356schalkms merged 1 commit intodetekt:masterfrom
schalkms merged 1 commit intodetekt:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3356 +/- ##
=========================================
Coverage 80.27% 80.27%
Complexity 2717 2717
=========================================
Files 445 445
Lines 8238 8238
Branches 1563 1563
=========================================
Hits 6613 6613
Misses 785 785
Partials 840 840 Continue to review full report at Codecov.
|
picklebento
changed the title
picklebento
force-pushed
the
integ-gradle-plugin-test
branch
2 times, most recently
from
4f2ebb1 to
0af3381
Compare
schalkms
approved these changes
Jan 7, 2021
picklebento
force-pushed
the
integ-gradle-plugin-test
branch
from
0af3381 to
ee727f5
Compare
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #3324 by creating a different sourceSet/configuration to run integration tests using
Gradle Testkit.Note that
DetektPluginTest.ktremains in the test set, as it is testing againstGradle API, notGradle Testkit.Gradle documentation on test kit: https://docs.gradle.org/current/userguide/test_kit.html