-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Gradle integration tests #3489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3489 +/- ##
============================================
- Coverage 80.52% 79.74% -0.79%
+ Complexity 2888 2864 -24
============================================
Files 459 459
Lines 8643 8643
Branches 1674 1674
============================================
- Hits 6960 6892 -68
- Misses 763 841 +78
+ Partials 920 910 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻👏🏻 Nice refactor. I had no idea that detektMain was running the android tasks too. Nor the ignored configuration. I have work to do Monday morning at work 😅.
643b61d
to
09015ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just one note, should we merge #3453 before this?
Good call. Now we have one remaining non-testkit gradle unit test |
This PR serves two purposes:
intTest
source set and we cannot launch those tests in IDE. IDEA-218815 is an issue that's applicable to a lot of people in the recent versions. So I am planning to remove theintTest
and merge it back totest
.Note
While this mostly maintains the test coverage, I did reduce the following test cases:
com.android.test
is removed. Since there are many other plugin's likecom.android.dynamic-feature
,com.android.lint
andcom.android.reporting
, it is not necessary to test all different android plugins. As long as the base plugincom.android.build.gradle.api.AndroidBasePlugin
is applied, we do not need to worry too much about other subplugins.sally
fromname
. This does not provide too much value in my opinion while contributes significantly the lines of code in tests.