Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce --max-issues flag for cli - #2267 #3391

Merged
merged 5 commits into from
Jan 24, 2021
Merged

Conversation

arturbosch
Copy link
Member

Part 2 of replacing the --fail-fast flag

@arturbosch arturbosch added this to the 1.16.0 milestone Jan 19, 2021
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #3391 (70f9d7b) into master (221d7a3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3391      +/-   ##
============================================
- Coverage     80.45%   80.44%   -0.02%     
- Complexity     2739     2746       +7     
============================================
  Files           448      448              
  Lines          8280     8284       +4     
  Branches       1572     1585      +13     
============================================
+ Hits           6662     6664       +2     
+ Misses          771      767       -4     
- Partials        847      853       +6     
Impacted Files Coverage Δ Complexity Δ
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 82.00% <100.00%> (+1.56%) 0.00 <0.00> (ø)
...t/rules/coroutines/SuspendFunWithFlowReturnType.kt 71.42% <0.00%> (-14.29%) 7.00% <0.00%> (ø%)
...n/io/gitlab/arturbosch/detekt/core/DetektResult.kt 90.00% <0.00%> (-10.00%) 7.00% <0.00%> (ø%)
...ain/kotlin/io/github/detekt/metrics/LinesOfCode.kt 93.10% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...b/arturbosch/detekt/rules/complexity/LargeClass.kt 91.17% <0.00%> (-5.89%) 12.00% <0.00%> (ø%)
...b/arturbosch/detekt/rules/complexity/LongMethod.kt 84.09% <0.00%> (-4.55%) 16.00% <0.00%> (ø%)
...o/gitlab/arturbosch/detekt/invoke/DetektInvoker.kt 48.38% <0.00%> (-1.62%) 0.00% <0.00%> (ø%)
...n/io/github/detekt/report/sarif/RuleDescriptors.kt 20.00% <0.00%> (-1.06%) 0.00% <0.00%> (ø%)
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt 82.60% <0.00%> (ø) 16.00% <0.00%> (ø%)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221d7a3...70f9d7b. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the documentation should also get some love with an update concerning the new flag. Otherwise, this pr looks nice.

Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment

This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants