jcenter() -> mavenCentral()

[cortinico]

This is a tentative PR to remove our dependency on jcenter().

The impact on our project is:

• We're currently depending on kotlix-html that hasn't been migrated to JCenter yet (see upload to maven central Kotlin/kotlinx.html#81 & Stop relying on jcenter & bintray Kotlin/kotlinx.html#173)
• We have several older versions of Detekt on JCenter that haven't been migrated to Central yet.

I'll keep this PR updated as things evolve.

Fixes #3461

[ber4444]

This PR is incorrect, as they do not seem to be moving to mavenCentral, instead they use their own JetBrains repo, see #3642

[IRus]

This PR is incorrect, as they do not seem to be moving to mavenCentral, instead they use their own JetBrains repo, see #3642

There are no evidence that it's true. kotlinx.html will be defenitly presented in mavenCentral, you can track that issue: Kotlin/kotlinx.html#173

[smyrick]

We could migrate to pull the dependency from JetBrains Space as an alternative

Kotlin/kotlinx.html#173 (comment)

[BraisGabin]

We could migrate to pull the dependency from JetBrains Space as an alternative

Kotlin/kotlinx.html#173 (comment)

What do we get from that? JetBrains will move this to mavenCental. And jCenter will be up for nearly one year. If someone is in a hurry to remove jcenter they can do it. But I don't think that we should promote the JetBrains repository. They are not promoting it so I don't see the point for us to promote it.

As I said, if someone is in a hurry to remove jCenter can use the JetBrains repository but I think that we should wait.

[dsvensson]

kotlinx.html is on central now, Kotlin/kotlinx.html#173 (comment)

[BraisGabin]

I didn't realiced that this one was already a PR. And I did it again: main...remove-jcenter

My branch is a bit more aggresive. No idea if that's ok or not. But I think that this changes should be done: 37fcead

[G00fY2]

kotlinx.html 0.7.3 is available in mavenCentral

Edit: Too late, didn't notice the two comments before.

[hsz]

Please note that v0.7.2 was not published to MC – just the newest release, v0.7.3.

[cortinico]

I didn't realiced that this one was already a PR. And I did it again: main...remove-jcenter
My branch is a bit more aggresive. No idea if that's ok or not. But I think that this changes should be done: 37fcead

Rebased and included your changes 👌

[dsvensson]

@cortinico Shouldn't you also bump to 0.7.3 in detekt-bom?

[cortinico]

@cortinico Shouldn't you also bump to 0.7.3 in detekt-bom?

Yup you're right :)

[chao2zhang]

We probably need to bump to the latest version of dokka to avoid pulling kotlinx.html:0.7.2

https://gist.github.com/chao2zhang/6522db3677cbd3799ad70596d2f51779

[codecov]

Codecov Report

Merging #3455 (dd6ec49) into main (20bc74c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3455   +/-   ##
=========================================
  Coverage     78.04%   78.04%           
  Complexity     2883     2883           
=========================================
  Files           473      473           
  Lines          9302     9302           
  Branches       1767     1767           
=========================================
  Hits           7260     7260           
  Misses         1078     1078           
  Partials        964      964           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bc74c...dd6ec49. Read the comment docs.

[chao2zhang]

Once we publish the new version, we should be able to remove these references in our gradle integration test.

[dsvensson]

What timeframe do you see for this to be a part of a release?

[BraisGabin]

I would say "soon" but that's completely subjective. There is not ETA but we know that this is something that a lot of users are wating for so we will try to create a new version "soon".

[cortinico]

1.17.0-RC1 is out and includes this change https://github.com/detekt/detekt/releases/tag/v1.17.0-RC1
Please give it a try so we can release a production version asap 👍

[theexiile1305]

@cortinico
I've tried the newest version 1.17.0-RC1 out like the following configuration in the build.gradle.kts

repositories {
    mavenCentral()
}

plugins {
    ...
    id("io.gitlab.arturbosch.detekt") version "1.17.0-RC1"
}

Unfortunately the plugin doesn't work as expected. The execution of ./gradlew detekt produces the following error:

> Task :detekt FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':detekt'.
> Could not resolve all files for configuration ':detekt'.
   > Could not find io.gitlab.arturbosch.detekt:detekt-cli:1.17.0.
     Required by:
         project :

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org