Enable SARIF output format by default#3543
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3543 +/- ##
=========================================
Coverage 78.03% 78.04%
Complexity 2837 2837
=========================================
Files 467 467
Lines 9153 9152 -1
Branches 1742 1742
=========================================
Hits 7143 7143
+ Misses 1068 1067 -1
Partials 942 942
Continue to review full report at Codecov.
|
schalkms
approved these changes
Mar 12, 2021
BraisGabin
approved these changes
Mar 13, 2021
BraisGabin
left a comment
Member
There was a problem hiding this comment.
Should we wait a bit to merge this one? It seems that 1.16.0 have some issues so maybe we create 1.16.1 and we don't want this in that version.
Member
Author
|
Sounds good. This PR is tagged with 1.17 so we can definitely wait a little bit. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that we have 1.16.0 release, this PR flips the default flag to true for SARIF output format. See #3360
(I also removed the dependency for
:detekt-report-sarifto:detekt-tooling.