Skip to content

Enable SARIF output format by default#3543

Merged
picklebento merged 2 commits into
detekt:mainfrom
picklebento:enable-sarif
Apr 6, 2021
Merged

Enable SARIF output format by default#3543
picklebento merged 2 commits into
detekt:mainfrom
picklebento:enable-sarif

Conversation

@picklebento

Copy link
Copy Markdown
Member

Given that we have 1.16.0 release, this PR flips the default flag to true for SARIF output format. See #3360

(I also removed the dependency for :detekt-report-sarif to :detekt-tooling.

@codecov

codecov Bot commented Mar 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3543 (0a4988c) into main (14d3b5c) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3543   +/-   ##
=========================================
  Coverage     78.03%   78.04%           
  Complexity     2837     2837           
=========================================
  Files           467      467           
  Lines          9153     9152    -1     
  Branches       1742     1742           
=========================================
  Hits           7143     7143           
+ Misses         1068     1067    -1     
  Partials        942      942           
Impacted Files Coverage Δ Complexity Δ
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/kotlin/io/github/detekt/report/sarif/SarifDsl.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d3b5c...0a4988c. Read the comment docs.

@picklebento picklebento added this to the 1.17.0 milestone Mar 12, 2021

@BraisGabin BraisGabin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait a bit to merge this one? It seems that 1.16.0 have some issues so maybe we create 1.16.1 and we don't want this in that version.

@picklebento

Copy link
Copy Markdown
Member Author

Sounds good. This PR is tagged with 1.17 so we can definitely wait a little bit.

Base automatically changed from master to main March 21, 2021 18:44
@picklebento picklebento merged commit 06baaa8 into detekt:main Apr 6, 2021
@picklebento picklebento deleted the enable-sarif branch April 6, 2021 18:25
@cortinico cortinico added the notable changes Marker for notable changes in the changelog label May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notable changes Marker for notable changes in the changelog reports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants