Fix rules not appearing in the sarif output - #3556
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3556 +/- ##
=========================================
Coverage 77.53% 77.53%
Complexity 2829 2829
=========================================
Files 464 464
Lines 8769 8769
Branches 1713 1713
=========================================
Hits 6799 6799
Misses 1046 1046
Partials 924 924
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Mar 15, 2021
Member
Author
|
picklebento#9 This is an example without the fix in this PR The inline display of error works. But when we click "Show more details", there is no more details like the link to the detekt doc |
schalkms
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This partially addresses #3554. The problem is that all the detekt extensions are loaded by plugin loader, which also loads
SarifOutputReport. However,ServiceLoader.load(Class<>)by default will with the current thread context's loader, which is the main detekt loader and will not load anything.I would recommend merging this now instead of waiting for the next major release.
Before detekt.sarif
After detekt.sarif - SARIF validation passed