Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message -> buildUponDefaultConfig instead of buildOnDefaultConfig #3572

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 18, 2021

when migrating detekt version, I came thru this error and the field name is likely wrong.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #3572 (b82377e) into master (dde5fae) will not change coverage.
The diff coverage is 0.00%.

❗ Current head b82377e differs from pull request most recent head 0ed98cf. Consider uploading reports for the commit 0ed98cf to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3572   +/-   ##
=========================================
  Coverage     77.53%   77.53%           
  Complexity     2829     2829           
=========================================
  Files           464      464           
  Lines          8769     8769           
  Branches       1713     1713           
=========================================
  Hits           6799     6799           
  Misses         1046     1046           
  Partials        924      924           
Impacted Files Coverage Δ Complexity Δ
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...tlab/arturbosch/detekt/DetektCreateBaselineTask.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde5fae...0ed98cf. Read the comment docs.

Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when migrating detekt version, I came thru this error and the field name is likely wrong.

Thanks for fixing this (related to #3567).
Can you just split the string as the line is getting to long (that's why the CI is failing).

@chao2zhang chao2zhang added this to the 1.16.1 milestone Mar 18, 2021
@marandaneto
Copy link
Contributor Author

done, just a quick heads up, detektFormat ran but didn't format anything, so I did manually.

@schalkms schalkms merged commit 1b45d78 into detekt:master Mar 19, 2021
@chao2zhang chao2zhang modified the milestones: 1.16.1, 1.17.0 Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants