Skip to content

Support Gradle config cache in detekt's build - #3574

Merged
3flex merged 5 commits into
detekt:mainfrom
3flex:config-cache
Mar 22, 2021
Merged

3flex merged 5 commits into
detekt:mainfrom
3flex:config-cache

Conversation

@3flex

@3flex 3flex commented Mar 18, 2021

Copy link
Copy Markdown
Member

A few improvements to eventually allow the Gradle configuration cache to be used when building detekt.

There are changes required in some Gradle plugins used by the detekt build before this will work:

@codecov

codecov Bot commented Mar 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3574 (fa556ae) into main (aa46448) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3574   +/-   ##
=========================================
  Coverage     77.53%   77.53%           
  Complexity     2835     2835           
=========================================
  Files           464      464           
  Lines          8779     8779           
  Branches       1720     1720           
=========================================
  Hits           6807     6807           
  Misses         1046     1046           
  Partials        926      926           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa46448...fa556ae. Read the comment docs.

@picklebento picklebento left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to turn on org.gradle.unsafe.configuration-cache=true? Or is this PR purely to fix issues to be prepared for the work?

Comment thread gradle/wrapper/gradle-wrapper.properties Outdated
Comment thread buildSrc/src/main/kotlin/module.gradle.kts
@3flex

3flex commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

It's just to fix issues in the build for now. As I mentioned there are third party Gradle plugin updates that are required first, but once they've made fixes and detekt updates those dependencies it should be OK to enable.

@picklebento picklebento added this to the 1.17.0 milestone Mar 19, 2021
Base automatically changed from master to main March 21, 2021 18:44
@3flex
3flex merged commit a847869 into detekt:main Mar 22, 2021
@BraisGabin

Copy link
Copy Markdown
Member

@3flex should we have an issue to track the things that we need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants