-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Gradle config cache in detekt's build #3574
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3574 +/- ##
=========================================
Coverage 77.53% 77.53%
Complexity 2835 2835
=========================================
Files 464 464
Lines 8779 8779
Branches 1720 1720
=========================================
Hits 6807 6807
Misses 1046 1046
Partials 926 926 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to turn on org.gradle.unsafe.configuration-cache=true
? Or is this PR purely to fix issues to be prepared for the work?
It's just to fix issues in the build for now. As I mentioned there are third party Gradle plugin updates that are required first, but once they've made fixes and detekt updates those dependencies it should be OK to enable. |
@3flex should we have an issue to track the things that we need to do? |
A few improvements to eventually allow the Gradle configuration cache to be used when building detekt.
There are changes required in some Gradle plugins used by the detekt build before this will work: