-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple Gradle projects #3611
Decouple Gradle projects #3611
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3611 +/- ##
============================================
- Coverage 77.52% 77.50% -0.03%
+ Complexity 2837 2834 -3
============================================
Files 464 464
Lines 8783 8783
Branches 1721 1721
============================================
- Hits 6809 6807 -2
Misses 1047 1047
- Partials 927 929 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great boost to the build time 👏🏻👏🏻
@@ -14,7 +14,7 @@ dependencies { | |||
implementation(project(":detekt-report-xml")) | |||
implementation(project(":detekt-report-sarif")) | |||
|
|||
testImplementation(project(":detekt-rules")) | |||
testRuntimeOnly(project(":detekt-rules")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we have at least one unit test that do far too much. Otherwise we should not need this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there are a couple of places detekt-rules is used when it maybe shouldn't be.
I'll open a new issue for that because it would help further with build times when iterating on rules.
This reduces the number of subprojects that have to be recompiled when there's a change to one of the rules, saving quite a bit of time when building the project.
The most interesting change is in the detekt-cli build file since the shadow jar config has changed. The new config can be verified by executing the resulting jar with
--debug
and confirming that the bundled rulesets have been registered.