Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generator test coverage #3622

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

marschwar
Copy link
Contributor

This extends the generator tests to cover

  • rule set configuration parameters
  • list properties in rules

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #3622 (c25f8a9) into main (36edd4c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3622      +/-   ##
============================================
+ Coverage     78.22%   78.23%   +0.01%     
  Complexity     2826     2826              
============================================
  Files           466      466              
  Lines          9136     9136              
  Branches       1724     1724              
============================================
+ Hits           7147     7148       +1     
+ Misses         1059     1057       -2     
- Partials        930      931       +1     
Impacted Files Coverage Δ Complexity Δ
...gitlab/arturbosch/detekt/generator/out/Markdown.kt 21.42% <0.00%> (ø) 4.00 <0.00> (ø)
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 77.08% <0.00%> (+2.08%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36edd4c...c25f8a9. Read the comment docs.

@schalkms schalkms merged commit 14f655e into detekt:main Mar 29, 2021
@schalkms schalkms added this to the 1.17.0 milestone Mar 29, 2021
@BraisGabin BraisGabin mentioned this pull request Mar 30, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 1, 2021
@marschwar marschwar deleted the improve-test-coverage branch May 24, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants