Warnings as errors

[BraisGabin]

This PR removes all the current warnigns in the project and enables warningsAsErrors in CI as before #2981. It was removed for some problems with Kotlin 1.4 that are fixed now so it's safe to add it again.

[BraisGabin]

I have no idea what this code does and I can't find any alternative to this. The other suppressions are safe because we are suppressing our own deprecations and that's fine. But this case is different. What do you think? The problem is that if we don't fix this we can't enable warningsAsErrors again.

Other option would be to disable warningsAsErrors just for this module.

What do you think?

[chao2zhang]

https://github.com/pinterest/ktlint/blob/235a414be565a49568c26f1b30d396d347efbd0f/ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/internal/KotlinPsiFileFactory.kt#L111

The code here seems to enable AST mutations.

[BraisGabin]

😕 so ktlint still have that deprecated code... Any idea about how to fix this deprecation properly? How should we proceed here?

[chao2zhang]

The replacement can be found here https://github.com/JetBrains/intellij-community/blob/master/platform/extensions/src/com/intellij/openapi/extensions/Extensions.java#L34. Would you mind trying it and verify the AST mutation still works?

[codecov]

Codecov Report

Merging #3646 (b43fb97) into main (709f879) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head b43fb97 differs from pull request most recent head b732719. Consider uploading reports for the commit b732719 to get more accurate results

@@             Coverage Diff              @@
##               main    #3646      +/-   ##
============================================
- Coverage     78.12%   78.11%   -0.02%     
+ Complexity     2837     2835       -2     
============================================
  Files           467      467              
  Lines          9143     9143              
  Branches       1737     1737              
============================================
- Hits           7143     7142       -1     
- Misses         1058     1059       +1     
  Partials        942      942              

Impacted Files	Coverage Δ	Complexity Δ
...kotlin/io/gitlab/arturbosch/detekt/api/Location.kt	77.77% <ø> (-3.71%)	5.00 <0.00> (-2.00)
.../kotlin/io/gitlab/arturbosch/detekt/api/RuleSet.kt	70.00% <ø> (ø)	3.00 <0.00> (ø)
...tlab/arturbosch/detekt/DetektCreateBaselineTask.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...o/gitlab/arturbosch/detekt/internal/SharedTasks.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...kotlin/io/gitlab/arturbosch/detekt/api/Findings.kt	62.50% <100.00%> (ø)	0.00 <0.00> (ø)
.../core/reporting/console/FileBasedFindingsReport.kt	100.00% <100.00%> (ø)	5.00 <0.00> (ø)
...n/kotlin/io/github/detekt/parser/DetektPomModel.kt	70.58% <100.00%> (ø)	5.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709f879...b732719. Read the comment docs.

[chao2zhang]

We can delay Extensions.getRootArea() to a follow-PR. The urgency is to avoid adding new violations as warnings.

[BraisGabin]

I created #3683 so we don't forget about it.