Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 7 #3689

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Upgrade to Gradle 7 #3689

merged 1 commit into from
Apr 23, 2021

Conversation

chao2zhang
Copy link
Member

This is to prepare for #3688

@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 20, 2021
@3flex
Copy link
Member

3flex commented Apr 21, 2021

Are you working on the build failures?

I don't mind doing it but I don't want to duplicate effort.

@chao2zhang
Copy link
Member Author

Thanks for offering the help. I am attempting to fix this in #3691

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #3689 (9007e8e) into main (9babc59) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3689   +/-   ##
=========================================
  Coverage     78.00%   78.00%           
  Complexity     2870     2870           
=========================================
  Files           471      471           
  Lines          9275     9275           
  Branches       1766     1766           
=========================================
  Hits           7235     7235           
  Misses         1078     1078           
  Partials        962      962           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9babc59...9007e8e. Read the comment docs.

@3flex
Copy link
Member

3flex commented Apr 22, 2021

Tests are flaky... is that a known issue with the detekt build? I had to rerun the checks twice before everything came up green.

@3flex 3flex closed this Apr 22, 2021
@3flex 3flex reopened this Apr 22, 2021
@chao2zhang
Copy link
Member Author

is that a known issue with the detekt build?

I have been noticing that lately as well. Since we are seeing out-of-memory issues, the first thing I would like to try is to bump Gradle JVM heap sizes.

@3flex 3flex merged commit 7aaefb9 into detekt:main Apr 23, 2021
@cortinico cortinico added the dependencies Pull requests that update a dependency file label May 1, 2021
chao2zhang added a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
@chao2zhang chao2zhang deleted the gradle7 branch May 21, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants