Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issue in :detekt-rules-style:compileTestKotlin #3691

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

chao2zhang
Copy link
Member

No description provided.

@chao2zhang chao2zhang mentioned this pull request Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #3691 (5082d7c) into main (da8676d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3691      +/-   ##
============================================
+ Coverage     77.98%   78.00%   +0.01%     
+ Complexity     2872     2870       -2     
============================================
  Files           471      471              
  Lines          9276     9275       -1     
  Branches       1766     1766              
============================================
+ Hits           7234     7235       +1     
  Misses         1078     1078              
+ Partials        964      962       -2     
Impacted Files Coverage Δ Complexity Δ
.../main/kotlin/io/github/detekt/parser/KtCompiler.kt 76.47% <0.00%> (-0.81%) 5.00% <0.00%> (-3.00%)
...rbosch/detekt/rules/complexity/ComplexInterface.kt 93.75% <0.00%> (+0.41%) 14.00% <0.00%> (+1.00%)
...kt/rules/style/LibraryEntitiesShouldNotBePublic.kt 86.36% <0.00%> (+3.03%) 7.00% <0.00%> (+2.00%)
...lin/io/github/detekt/report/xml/XmlOutputReport.kt 95.23% <0.00%> (+3.93%) 5.00% <0.00%> (-2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8676d...5082d7c. Read the comment docs.

@chao2zhang chao2zhang merged commit 9babc59 into main Apr 21, 2021
@chao2zhang chao2zhang deleted the fixcompilation branch April 21, 2021 21:08
@cortinico cortinico added this to the 1.17.0 milestone May 1, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 1, 2021
chao2zhang added a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants