Publish build scans for all CI builds#3710
Merged
picklebento merged 3 commits intomainfrom Apr 28, 2021
Merged
Conversation
Contributors should manually agree to ToS when submitting build scans. As the Gradle doc says: > Be careful not to commit agreement to the terms of service into a project that may be built by others. https://docs.gradle.com/enterprise/gradle-plugin/#connecting_to_scans_gradle_com
Codecov Report
@@ Coverage Diff @@
## main #3710 +/- ##
=========================================
Coverage 78.04% 78.04%
Complexity 2883 2883
=========================================
Files 473 473
Lines 9302 9302
Branches 1767 1767
=========================================
Hits 7260 7260
Misses 1078 1078
Partials 964 964 Continue to review full report at Codecov.
|
picklebento
approved these changes
Apr 28, 2021
| buildScan { | ||
| termsOfServiceUrl = "https://gradle.com/terms-of-service" | ||
| termsOfServiceAgree = "yes" | ||
| if (isCiBuild) { |
Member
There was a problem hiding this comment.
Nice! I had wanted to do an if check here since we should not sign an agreement for others building our project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.