Fix ModifierOrder to support value class #3719
Conversation
eygraber
force-pushed
the
fix-modifier-order-value-class
branch
from
593a288
to
cb1758b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3719 +/- ##
=========================================
Coverage 83.58% 83.58%
Complexity 3055 3055
=========================================
Files 456 456
Lines 8916 8917 +1
Branches 1752 1752
=========================================
+ Hits 7452 7453 +1
Misses 541 541
Partials 923 923
Continue to review full report at Codecov.
|
eygraber
force-pushed
the
fix-modifier-order-value-class
branch
9 times, most recently
from
a9064d9
to
d2b87af
Compare
eygraber
force-pushed
the
fix-modifier-order-value-class
branch
2 times, most recently
from
566bc32
to
2d5da7e
Compare
eygraber
force-pushed
the
fix-modifier-order-value-class
branch
from
2d5da7e
to
d25098e
Compare
| @@ -75,6 +76,7 @@ class ModifierOrder(config: Config = Config.empty) : Rule(config) { | |||
| ENUM_KEYWORD, ANNOTATION_KEYWORD, FUN_KEYWORD, | |||
| COMPANION_KEYWORD, | |||
| INLINE_KEYWORD, | |||
| VALUE_KEYWORD, | |||
There was a problem hiding this comment.
It seems reasonable to put value here because value class is inline class. However, would you mind creating a PR for Kotlin coding convention here since it does not include the value modifier yet?
There was a problem hiding this comment.
I just created that PR: JetBrains/kotlin-web-site#2300
Should we wait for it to be merged before merging this? Or can we merge it and revert it in case it is rejected?
There was a problem hiding this comment.
I am inclined to merge it now since this will impact the correctness when running Detekt on Kotlin 1.5 code. See https://github.com/detekt/detekt/pull/3810/files#r637354618
|
@cortinico @chao2zhang can we please have a new release that'd include this fix? |
cortinico
changed the title
On top of #3718
Fixes #3717