Fix ModifierOrder to support value class

[eygraber]

On top of #3718

Fixes #3717

[codecov]

Codecov Report

Merging #3719 (d25098e) into main (22eec63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #3719   +/-   ##
=========================================
  Coverage     83.58%   83.58%           
  Complexity     3055     3055           
=========================================
  Files           456      456           
  Lines          8916     8917    +1     
  Branches       1752     1752           
=========================================
+ Hits           7452     7453    +1     
  Misses          541      541           
  Partials        923      923           

Impacted Files	Coverage Δ	Complexity Δ
...lab/arturbosch/detekt/rules/style/ModifierOrder.kt	100.00% <100.00%> (ø)	3.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22eec63...d25098e. Read the comment docs.

[picklebento]

It seems reasonable to put value here because value class is inline class. However, would you mind creating a PR for Kotlin coding convention here since it does not include the value modifier yet?

[BraisGabin]

I just created that PR: JetBrains/kotlin-web-site#2300

Should we wait for it to be merged before merging this? Or can we merge it and revert it in case it is rejected?

[picklebento]

I am inclined to merge it now since this will impact the correctness when running Detekt on Kotlin 1.5 code. See https://github.com/detekt/detekt/pull/3810/files#r637354618

[netroy]

@cortinico @chao2zhang can we please have a new release that'd include this fix?