Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the org.gradle.dependency.bundling attribute to external #3738

Merged
merged 1 commit into from
May 5, 2021

Conversation

cortinico
Copy link
Member

This fixes the failures on the PR #3727 such as:

    > Could not resolve all files for configuration ':child1:detekt'.
       > Could not resolve io.gitlab.arturbosch.detekt:detekt-cli:1.17.0-RC2.
         Required by:
             project :child1
          > Cannot choose between the following variants of io.gitlab.arturbosch.detekt:detekt-cli:1.17.0-RC2:
              - runtimeElements
              - shadowRuntimeElements
            All of them match the consumer attributes:
              - Variant 'runtimeElements' capability io.gitlab.arturbosch.detekt:detekt-cli:1.17.0-RC2:
                  - Unmatched attributes:
                      - Provides org.gradle.category 'library' but the consumer didn't ask for it
                      - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                      - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
                      - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
                      - Provides org.gradle.status 'release' but the consumer didn't ask for it
                      - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
                      - Provides org.jetbrains.kotlin.localToProject 'public' but the consumer didn't ask for it
                      - Provides org.jetbrains.kotlin.platform.type 'jvm' but the consumer didn't ask for it
              - Variant 'shadowRuntimeElements' capability io.gitlab.arturbosch.detekt:detekt-cli:1.17.0-RC2:
                  - Unmatched attributes:
                      - Provides org.gradle.category 'library' but the consumer didn't ask for it
                      - Provides org.gradle.dependency.bundling 'shadowed' but the consumer didn't ask for it
                      - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
                      - Provides org.gradle.status 'release' but the consumer didn't ask for it
                      - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
                      -

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #3738 (de2a47f) into main (9dd0c8b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3738      +/-   ##
============================================
- Coverage     78.04%   78.01%   -0.03%     
  Complexity     2883     2883              
============================================
  Files           473      473              
  Lines          9300     9303       +3     
  Branches       1767     1767              
============================================
  Hits           7258     7258              
- Misses         1078     1081       +3     
  Partials        964      964              
Impacted Files Coverage Δ Complexity Δ
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 5.88% <0.00%> (-0.37%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd0c8b...de2a47f. Read the comment docs.

@3flex
Copy link
Member

3flex commented May 5, 2021

Do you know why this issue came up?

It seems like something to fix on the publishing side, by only publishing the shadow variant (or non-shadow which I believe is what is resolved in current versions).

@chao2zhang chao2zhang added this to the 1.17.0 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants