Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore gradle plugin in codecov #3740

Merged
merged 2 commits into from
May 11, 2021
Merged

Conversation

BraisGabin
Copy link
Member

The code coverage reports from codecov about our gradle plugin aren't correct. For that reason it's better to ignore them so we don't get that noise in our PRs.

Following this documentation: https://docs.codecov.io/docs/ignoring-paths

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #3740 (6657464) into main (b2c13aa) will increase coverage by 4.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3740      +/-   ##
============================================
+ Coverage     78.75%   83.47%   +4.71%     
+ Complexity     2900     2891       -9     
============================================
  Files           473      451      -22     
  Lines          9336     8733     -603     
  Branches       1722     1652      -70     
============================================
- Hits           7353     7290      -63     
+ Misses         1075      544     -531     
+ Partials        908      899       -9     
Impacted Files Coverage Δ Complexity Δ
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt
...ab/arturbosch/detekt/extensions/DetektExtension.kt
...tlab/arturbosch/detekt/DetektCreateBaselineTask.kt
...b/arturbosch/detekt/extensions/DetektReportType.kt
.../gitlab/arturbosch/detekt/internal/FileMangling.kt
...lin/io/gitlab/arturbosch/detekt/KotlinExtension.kt
...o/gitlab/arturbosch/detekt/internal/DetektPlain.kt
.../arturbosch/detekt/internal/DetektMultiplatform.kt
...tlab/arturbosch/detekt/extensions/DetektReports.kt
...gitlab/arturbosch/detekt/report/ReportMergeTask.kt
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c13aa...6657464. Read the comment docs.

@3flex
Copy link
Member

3flex commented May 5, 2021

Does filtering out the project in the root build.gradle.kts have the same effect?

There are already some subprojects that are ignored that way, might add well use the same method if possible.

@chao2zhang chao2zhang added this to the 1.17.0 milestone May 5, 2021
@chao2zhang
Copy link
Member

Does filtering out the project in the root build.gradle.kts have the same effect?

Good point. The build.gradle.kts configures jacoco test report while codecov.yml configures the code coverage CI.
If we want to report code coverage for detekt-gradle-plugin separately, I believe modifying codecov.yml as shown in this PR would be a reasonable choice.

@schalkms
Copy link
Member

schalkms commented May 5, 2021

Does filtering out the project in the root build.gradle.kts have the same effect?

Good point. The build.gradle.kts configures jacoco test report while codecov.yml configures the code coverage CI.
If we want to report code coverage for detekt-gradle-plugin separately, I believe modifying codecov.yml as shown in this PR would be a reasonable choice.

Yes, this would be the preferred way.

@3flex
Copy link
Member

3flex commented May 5, 2021

:detekt-gradle-plugin:test task should also be skipped on the code coverage CI job which will speed it up. It doesn't currently use the build cache and the Gradle test task takes 12 minutes (only part of run time is in parallel with other tasks).

https://scans.gradle.com/s/dt73yepgj2gxm/timeline

@BraisGabin BraisGabin force-pushed the ignore-gradle-plugin-codecov branch from d59de2a to 525296e Compare May 8, 2021 10:14
@BraisGabin BraisGabin force-pushed the ignore-gradle-plugin-codecov branch from 525296e to 6657464 Compare May 10, 2021 07:09
@BraisGabin BraisGabin merged commit d2e9966 into main May 11, 2021
@BraisGabin BraisGabin deleted the ignore-gradle-plugin-codecov branch May 11, 2021 07:24
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
* Ignore gradle plugin in codecov

* Don't run :detekt-gradle-plugin:test because we ignore those results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants