Remove Error from ThrowingExceptionsWithoutMessageOrCause because it's a common name - #4046
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4046 +/- ##
============================================
- Coverage 83.57% 83.57% -0.01%
Complexity 3186 3186
============================================
Files 459 459
Lines 9097 9096 -1
Branches 1772 1772
============================================
- Hits 7603 7602 -1
Misses 561 561
Partials 933 933
Continue to review full report at Codecov.
|
schalkms
approved these changes
Aug 14, 2021
picklebento
approved these changes
Aug 16, 2021
cortinico
approved these changes
Aug 17, 2021
marschwar
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erroris a common name for a class. If you have a class with that name and call it's constructor without any parameterThrowingExceptionsWithoutMessageOrCausecatches it as a false-positive. This is just a short term fix to avoid this type of false-positives but weThrowingExceptionsWithoutMessageOrCauseshould use Type solving to avoid all the possible false-positives.Fix #4037