Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Error from ThrowingExceptionsWithoutMessageOrCause because it's a common name #4046

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

BraisGabin
Copy link
Member

Error is a common name for a class. If you have a class with that name and call it's constructor without any parameter ThrowingExceptionsWithoutMessageOrCause catches it as a false-positive. This is just a short term fix to avoid this type of false-positives but we ThrowingExceptionsWithoutMessageOrCause should use Type solving to avoid all the possible false-positives.

Fix #4037

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #4046 (2ddd168) into main (deb39b3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4046      +/-   ##
============================================
- Coverage     83.57%   83.57%   -0.01%     
  Complexity     3186     3186              
============================================
  Files           459      459              
  Lines          9097     9096       -1     
  Branches       1772     1772              
============================================
- Hits           7603     7602       -1     
  Misses          561      561              
  Partials        933      933              
Impacted Files Coverage Δ
...eptions/ThrowingExceptionsWithoutMessageOrCause.kt 91.30% <ø> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb39b3...2ddd168. Read the comment docs.

@cortinico cortinico added this to the 1.18.1 milestone Aug 17, 2021
@BraisGabin BraisGabin merged commit 510ebc5 into main Aug 18, 2021
@BraisGabin BraisGabin deleted the fix-4037 branch August 18, 2021 12:22
cortinico pushed a commit to cortinico/detekt that referenced this pull request Aug 21, 2021
@cortinico cortinico mentioned this pull request Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThrowingExceptionsWithoutMessageOrCause should use Type Resolution to avoid False Positives
5 participants