Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid usage of DiagnosticUtils.getLineAndColumnInPsiFile #5109

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Jul 20, 2022

This is a refactor that I did to implement #5058 but that PR is big and this refactor only adds noise there so I'm moving this quick refactor here to reduce the number of changed files there.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Jul 20, 2022
@BraisGabin BraisGabin added this to the 1.22.0 milestone Jul 20, 2022
Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
@BraisGabin BraisGabin enabled auto-merge (squash) July 20, 2022 17:51
@BraisGabin BraisGabin merged commit 594a2da into main Jul 20, 2022
@BraisGabin BraisGabin deleted the getLineAndColumnInPsiFile branch July 20, 2022 17:58
VitalyVPinchuk pushed a commit to VitalyVPinchuk/detekt that referenced this pull request Jul 25, 2022
* Forbid usage of DiagnosticUtils.getLineAndColumnInPsiFile

* Update detekt-psi-utils/src/main/kotlin/io/github/detekt/psi/KtFiles.kt

Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>

Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api housekeeping Marker for housekeeping tasks and refactorings rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants