New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ruleauthors rule for Entity.from(x.nameIdentifier ?: x) -> Entity.atName(x) #5444
Merged
Commits on Oct 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 901a2fa - Browse repository at this point
Copy the full SHA 901a2faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f64190 - Browse repository at this point
Copy the full SHA 4f64190View commit details -
Configuration menu - View commit details
-
Copy full SHA for a72257c - Browse repository at this point
Copy the full SHA a72257cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31dc241 - Browse repository at this point
Copy the full SHA 31dc241View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6661975 - Browse repository at this point
Copy the full SHA 6661975View commit details -
Fix findings in Detekt codebase:
detekt-rules-libraries\src\main\kotlin\io\gitlab\arturbosch\detekt\libraries\ForbiddenPublicDataClass.kt:60:48: Recommended to use Entity.atName(klass) instead. [UseNamedLocation] detekt-rules-naming\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\naming\EnumNaming.kt:37:28: Recommended to use Entity.atName(enumEntry) instead. [UseNamedLocation] detekt-rules-complexity\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\complexity\TooManyFunctions.kt:144:28: Recommended to use Entity.atName(declaration) instead. [UseNamedLocation] detekt-rules-style\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\style\UseDataClass.kt:106:32: Recommended to use Entity.atName(klass) instead. [UseNamedLocation]
Configuration menu - View commit details
-
Copy full SHA for 76af16f - Browse repository at this point
Copy the full SHA 76af16fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa6b553 - Browse repository at this point
Copy the full SHA fa6b553View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8278a53 - Browse repository at this point
Copy the full SHA 8278a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa94de4 - Browse repository at this point
Copy the full SHA fa94de4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76d187b - Browse repository at this point
Copy the full SHA 76d187bView commit details
Commits on Oct 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c4df600 - Browse repository at this point
Copy the full SHA c4df600View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.