Automatically run detekt-generator on detekt-rules build task #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
reviewed
Dec 5, 2017
| violations += "Output file must be a directory." | ||
| } | ||
|
|
||
| if (!Files.exists(inputPath) || outputPath.isFile()) { |
There was a problem hiding this comment.
This must be inputPath.isFile() ?
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jar generated from the
detekt-generatormodule now has an--inputand--outputargument to define both directories.Adds
generateDocumentationtask in thedetekt-generatormodule. This builds and executes the generator jar to generate the latest documentation.I also added a rule that every time the
detekt-rulesmodule is built thegenerateDocumentationtask will be executed to update the documentation.