Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OptionalWhenBraces rule #6314

Merged

Conversation

mdemianova
Copy link
Contributor

Part of #6153.

OptionalWhenBraces is not needed anymore, because the new rule BracesOnWhenStatements implements the same functionality.

Deprecated for release/1.x branch.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/1.x@2865763). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/1.x    #6314   +/-   ##
==============================================
  Coverage               ?   84.92%           
  Complexity             ?     4040           
==============================================
  Files                  ?      569           
  Lines                  ?    13530           
  Branches               ?     2392           
==============================================
  Hits                   ?    11490           
  Misses                 ?      873           
  Partials               ?     1167           

@cortinico cortinico merged commit fa788eb into detekt:release/1.x Jul 29, 2023
21 checks passed
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against bd44fb4

@mdemianova mdemianova deleted the 6153-deprecate-optional-when-braces branch July 29, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants