Remove "native filesystem" warning on Windows #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this error when running Detekt:
WARN: Failed to initialize native filesystem for Windows
java.lang.RuntimeException: Could not find installation home path. Please make sure bin/idea.properties is present in the installation directory.
schalkms
approved these changes
Dec 21, 2017
|
|
||
| val psiFactory = KtPsiFactory(psiProject, false) | ||
|
|
||
| private fun createKotlinCoreEnvironment(): Project { |
There was a problem hiding this comment.
Maybe we can add a comment for clarity here.
|
|
||
| val psiFactory = KtPsiFactory(psiProject, false) | ||
|
|
||
| private fun createKotlinCoreEnvironment(): Project { | ||
| System.setProperty("idea.io.use.fallback", "true") |
There was a problem hiding this comment.
Interesting setting. Could you please explain the behavior of it?
There was a problem hiding this comment.
See #630 (comment) for background.
There was a problem hiding this comment.
While it's good to have the explanation in GitHub, it should really also go to the code as a comment, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error when running Detekt:
WARN: Failed to initialize native filesystem for Windows
java.lang.RuntimeException: Could not find installation home path. Please make sure bin/idea.properties is present in the installation directory.
Fixes #630