Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with deprecations in a type safe manner #6382

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

marschwar
Copy link
Contributor

This adds some type safety and explicitness to the entries in the deprecation.properties file. This way there is now only one file in which we have to know how the file is structured.

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #6382 (f02fff2) into main (c7b514f) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 95.45%.

@@             Coverage Diff              @@
##               main    #6382      +/-   ##
============================================
+ Coverage     85.24%   85.27%   +0.02%     
- Complexity     4013     4015       +2     
============================================
  Files           569      569              
  Lines         13398    13423      +25     
  Branches       2367     2367              
============================================
+ Hits          11421    11446      +25     
  Misses          814      814              
  Partials       1163     1163              
Files Changed Coverage Δ
...osch/detekt/core/config/validation/Deprecations.kt 93.93% <93.10%> (-6.07%) ⬇️
.../detekt/core/config/validation/ConfigValidation.kt 91.93% <100.00%> (ø)
.../validation/DeprecatedPropertiesConfigValidator.kt 100.00% <100.00%> (+11.11%) ⬆️
...fig/validation/InvalidPropertiesConfigValidator.kt 95.55% <100.00%> (+0.20%) ⬆️

@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against f02fff2

@marschwar marschwar merged commit 173f85e into detekt:main Aug 16, 2023
23 checks passed
@marschwar marschwar deleted the refactor/deprecations branch August 18, 2023 06:43
@cortinico cortinico added this to the 2.0.0 milestone Aug 18, 2023
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants