Consider deprecated rules as inactive when running allRules

[marschwar]

(quick) fixes #6336

Note: This PR targets the release/1.x branch instead of main.

Following this suggestion I hacked something up that should fix the issue short term. The idea is that all deprecated rules are considered as inactive in case detekt is run with the allRules option. We should probably find a better solution for the main branch.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release/1.x@5fc3df0). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/1.x    #6381   +/-   ##
==============================================
  Coverage               ?   84.93%           
  Complexity             ?     4043           
==============================================
  Files                  ?      569           
  Lines                  ?    13545           
  Branches               ?     2393           
==============================================
  Hits                   ?    11504           
  Misses                 ?      873           
  Partials               ?     1168           

[BraisGabin]

🤔 I'm not sure here. But what will happen if you read the deprecation file? You should be able to extract that list too, right? This way you don't need to hardcode the list of deprecated rules.

[marschwar]

But what will happen if you read the deprecation file? You should be able to extract that list too, right? This way you don't need to hardcode the list of deprecated rules.

I totally agree. This could be the actual fix for the main branch. This was meant to be a quick fix only in case we want to deliver something quickly. But I guess that still could be done here. I will update the PR.

[BraisGabin]

Then this PR should go against 2.0, right?

[marschwar]

Then this PR should go against 2.0, right?

No, it is intended for the 1.x only. For the 2.x I would like to use #6382.

[cortinico]

Works great for me 👍 Let's merge this so I can prepare .2

[marschwar]

Fix for 2.0 is #6413

[BraisGabin]

We can merge this, right?

[cortinico]

We can merge this, right?

Yup 👍