-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 1.23.2 #6574
Prepare release 1.23.2 #6574
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.x #6574 +/- ##
==============================================
Coverage ? 84.99%
Complexity ? 4054
==============================================
Files ? 569
Lines ? 13584
Branches ? 2406
==============================================
Hits ? 11546
Misses ? 858
Partials ? 1180 ☔ View full report in Codecov by Sentry. |
@detekt/maintainers can we please merge this before we start merging other PRs? |
|
||
##### Contributors | ||
|
||
We would like to thank the following contributors that made this release possible: @3flex, @BraisGabin, @ErdoganSeref, @Goooler, @Hexcles, @LeoColman, @PoisonedYouth, @TWiStErRob, @VirtualParticle, @arturbosch, @atulgpt, @bric3, @chao2zhang, @cortinico, @dzirbel, @eygraber, @kkocel, @lexa-diky, @marschwar, @matejdro, @mdemianova, @pablobaxter, @rmarquis, @segunfamisa, @severn-everett, @t-kameyama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that these users haven't contributed over various releases, but the list of PRs isn't as long as this list, so it doesn't look right... Something to look at next time, it's not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow up here as I believe we don't filter the contributor list properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be that PR authors AND PR reviewers/issue openers are also included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope the filtering was wrong:
Closes #6428
A new point release for the 1.x branch is long overdue!