Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.23.2 #6574

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

cortinico
Copy link
Member

Closes #6428

A new point release for the 1.x branch is long overdue!

@detekt-ci
Copy link
Collaborator

detekt-ci commented Oct 30, 2023

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.
Messages
📖

Thank you very much for making our website better ❤️!

Generated by 🚫 dangerJS against 5855db1

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/1.x@1e70456). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/1.x    #6574   +/-   ##
==============================================
  Coverage               ?   84.99%           
  Complexity             ?     4054           
==============================================
  Files                  ?      569           
  Lines                  ?    13584           
  Branches               ?     2406           
==============================================
  Hits                   ?    11546           
  Misses                 ?      858           
  Partials               ?     1180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortinico
Copy link
Member Author

@detekt/maintainers can we please merge this before we start merging other PRs?


##### Contributors

We would like to thank the following contributors that made this release possible: @3flex, @BraisGabin, @ErdoganSeref, @Goooler, @Hexcles, @LeoColman, @PoisonedYouth, @TWiStErRob, @VirtualParticle, @arturbosch, @atulgpt, @bric3, @chao2zhang, @cortinico, @dzirbel, @eygraber, @kkocel, @lexa-diky, @marschwar, @matejdro, @mdemianova, @pablobaxter, @rmarquis, @segunfamisa, @severn-everett, @t-kameyama
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that these users haven't contributed over various releases, but the list of PRs isn't as long as this list, so it doesn't look right... Something to look at next time, it's not a blocker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up here as I believe we don't filter the contributor list properly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that PR authors AND PR reviewers/issue openers are also included?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cortinico cortinico merged commit f539a60 into detekt:release/1.x Oct 31, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants