Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 1.23.2 #6574

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Prepare release 1.23.2 #6574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-logic/src/main/kotlin/Versions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget

object Versions {

const val DETEKT: String = "1.23.1"
const val DETEKT: String = "1.23.2"
const val SNAPSHOT_NAME: String = "main"
val JVM_TARGET: JvmTarget = JvmTarget.JVM_1_8

Expand Down
31 changes: 31 additions & 0 deletions website/src/pages/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,37 @@ keywords: [changelog, release-notes, migration]

# Changelog and Migration Guide

#### 1.23.2 - 2023-10-29

This is a point release for Detekt `1.23.0`, where we added support for Kotlin `1.9.10` and fixed several bugs that
got reported by the community.

##### Changelog

- Consider deprecated rules as inactive when running allRules [#6381](https://github.com/detekt/detekt/pull/6381)
- Fix inputstream leaking file descriptor in Gradle - [#6519](https://github.com/detekt/detekt/pull/6519)
- ForbiddenMethodCall - Handle sequence of overridden methods - [#6478](https://github.com/detekt/detekt/pull/6478)
- Function to return supported Kotlin version - [#6472](https://github.com/detekt/detekt/pull/6472)
- Fix false negative `IgnoredReturnValue` with scope functions - [#6446](https://github.com/detekt/detekt/pull/6446)
- UnconditionalJumpStatementInLoop: don't report a conditional break in a single body expression - [#6443](https://github.com/detekt/detekt/pull/6443)
- Fix reporting unused imports at file level - [#6390](https://github.com/detekt/detekt/pull/6390)
- OutdatedDocumentation - Detect param which private property documented as property - [#6372](https://github.com/detekt/detekt/pull/6372)
- NullableToStringCall: fix false negative in lambda - [#6352](https://github.com/detekt/detekt/pull/6352)
- Correctly set scheme for URIs in the SARIF report output - [#6331](https://github.com/detekt/detekt/pull/6331)
- SleepInsteadOfDelay - Find the parent for suspend check - [#6191](https://github.com/detekt/detekt/pull/6191)

##### Dependency Updates

- Update kotlin monorepo to v1.9.10 - [#6423](https://github.com/detekt/detekt/pull/6423)
- Update dependency gradle to v8.4 - [#6522](https://github.com/detekt/detekt/pull/6522)
- Update dependency gradle to v8.3 - [#6406](https://github.com/detekt/detekt/pull/6406)
- Update com.android.tools.build to 8.1.1 - [#6419](https://github.com/detekt/detekt/pull/6419)
- update dependency org.jetbrains.dokka to v1.9.10 - [#6549](https://github.com/detekt/detekt/pull/6549)

##### Contributors

We would like to thank the following contributors that made this release possible: @3flex, @BraisGabin, @ErdoganSeref, @Goooler, @Hexcles, @LeoColman, @PoisonedYouth, @TWiStErRob, @VirtualParticle, @arturbosch, @atulgpt, @bric3, @chao2zhang, @cortinico, @dzirbel, @eygraber, @kkocel, @lexa-diky, @marschwar, @matejdro, @mdemianova, @pablobaxter, @rmarquis, @segunfamisa, @severn-everett, @t-kameyama
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that these users haven't contributed over various releases, but the list of PRs isn't as long as this list, so it doesn't look right... Something to look at next time, it's not a blocker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up here as I believe we don't filter the contributor list properly

Copy link
Member

@TWiStErRob TWiStErRob Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that PR authors AND PR reviewers/issue openers are also included?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope the filtering was wrong:


#### 1.23.1 - 2023-07-30

This is a point release for Detekt `1.23.0`, where we added support for Kotlin `1.9.0` and fixed several bugs that
Expand Down