Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename *.yaml to *.yml so fixtures use expected line endings #661

Merged
merged 1 commit into from
Jan 7, 2018

Conversation

3flex
Copy link
Member

@3flex 3flex commented Jan 3, 2018

Fixes issue uncovered by #660.

Merge this before #660 to avoid build failures on master :)

@arturbosch
Copy link
Member

arturbosch commented Jan 7, 2018

Just for interest ... what is the correct spelling of the yaml ending .. ?
Thanks for the fixes!

@arturbosch arturbosch merged commit 97fd1f8 into detekt:master Jan 7, 2018
@3flex
Copy link
Member Author

3flex commented Jan 7, 2018

Officially it's *.yaml, but *.yml is apparently more commonly used (https://stackoverflow.com/questions/21059124/is-it-yaml-or-yml)

It doesn't matter to me at all, so long as .gitattribtues is in line with the extension being used by the YAML files in the tests to avoid issues when checking out on Windows.

If #660 is merged it will pick up those issues.

@3flex 3flex deleted the fix-line-endings branch January 7, 2018 22:12
@arturbosch arturbosch added this to the RC6-2 milestone Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants