Allow to enable allRules = true and buildUponDefaultConfig = true
#6844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
fix-allrules
branch
from
f445b1f
to
159ff67
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...re/src/test/kotlin/io/gitlab/arturbosch/detekt/core/tooling/WorkaroundConfigurationKtSpec.kt
Fixed
Show fixed
Hide fixed
BraisGabin
force-pushed
the
fix-allrules
branch
from
159ff67
to
3fce4e3
Compare
BraisGabin
force-pushed
the
fix-allrules
branch
from
3fce4e3
to
281402a
Compare
BraisGabin
force-pushed
the
fix-allrules
branch
2 times, most recently
from
69aeef9
to
2e614c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6844 +/- ##
============================================
+ Coverage 83.80% 83.83% +0.03%
- Complexity 3938 3942 +4
============================================
Files 578 578
Lines 12118 12105 -13
Branches 2511 2502 -9
============================================
- Hits 10155 10148 -7
+ Misses 709 707 -2
+ Partials 1254 1250 -4 ☔ View full report in Codecov by Sentry. |
BraisGabin
force-pushed
the
fix-allrules
branch
from
2e614c5
to
8e7ea39
Compare
BraisGabin
force-pushed
the
fix-allrules
branch
from
8e7ea39
to
bc81069
Compare
BraisGabin
force-pushed
the
fix-allrules
branch
from
bc81069
to
6bfdeed
Compare
schalkms
approved these changes
Mar 14, 2024
BraisGabin
force-pushed
the
fix-allrules
branch
from
2a97797
to
dba30b0
Compare
3flex
added a commit
to 3flex/detekt
that referenced
this pull request
Mar 15, 2024
… = true` (detekt#6844)" This reverts commit 9366ed0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4926 while it simplifies how all the configuration is handled.
I recommend to review this PR commit by commit.
I think that @TWiStErRob is going to be happy with this one ;)
Blocked by #6841 and #6782