Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the creation of Config #6848

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Jan 11, 2024

This PR just cleans the configuration code and moves the functions to where they should be declared. The next step would be to make those internal functions private and test all that code as a one unit. But I will leave that for later or for anyone willing to contribute.

Waiting for #6844

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.70%. Comparing base (0641174) to head (fbb26e0).
Report is 2 commits behind head on main.

Files Patch % Lines
...itlab/arturbosch/detekt/core/ProcessingSettings.kt 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6848      +/-   ##
============================================
- Coverage     84.71%   84.70%   -0.02%     
  Complexity     3975     3975              
============================================
  Files           576      575       -1     
  Lines         12140    12131       -9     
  Branches       2497     2495       -2     
============================================
- Hits          10285    10276       -9     
  Misses          621      621              
  Partials       1234     1234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin
Copy link
Member Author

Blocked by #7054

@BraisGabin BraisGabin force-pushed the simplify-creation-of-configuration branch from 8b0b9b5 to 0209325 Compare March 24, 2024 12:27
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Since this PR is around 1 month old, I would prefer rebasing to latest and if everything runs fine, merge it to main.

@schalkms schalkms force-pushed the simplify-creation-of-configuration branch from 0209325 to fbb26e0 Compare April 18, 2024 22:43
@schalkms schalkms merged commit 3a692a0 into main Apr 18, 2024
21 checks passed
@schalkms schalkms deleted the simplify-creation-of-configuration branch April 18, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants