-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the creation of Config
#6848
Conversation
...re/src/test/kotlin/io/gitlab/arturbosch/detekt/core/tooling/WorkaroundConfigurationKtSpec.kt
Fixed
Show fixed
Hide fixed
7710a9f
to
938ac41
Compare
cd80422
to
7ec0920
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6848 +/- ##
============================================
- Coverage 84.71% 84.70% -0.02%
Complexity 3975 3975
============================================
Files 576 575 -1
Lines 12140 12131 -9
Branches 2497 2495 -2
============================================
- Hits 10285 10276 -9
Misses 621 621
Partials 1234 1234 ☔ View full report in Codecov by Sentry. |
7ec0920
to
7341204
Compare
7341204
to
e2275aa
Compare
e2275aa
to
8d8be99
Compare
8d8be99
to
5f0d8fd
Compare
5f0d8fd
to
8b0b9b5
Compare
Blocked by #7054 |
8b0b9b5
to
0209325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Since this PR is around 1 month old, I would prefer rebasing to latest and if everything runs fine, merge it to main.
0209325
to
fbb26e0
Compare
This PR just cleans the configuration code and moves the functions to where they should be declared. The next step would be to make those
internal
functionsprivate
and test all that code as a one unit. But I will leave that for later or for anyone willing to contribute.Waiting for #6844