-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "naming" ruleset #690
Conversation
6e5c288
to
9eb396c
Compare
import io.gitlab.arturbosch.detekt.rules.naming.NamingRules | ||
import io.gitlab.arturbosch.detekt.rules.naming.PackageNaming | ||
import io.gitlab.arturbosch.detekt.rules.naming.TopLevelPropertyNaming | ||
import io.gitlab.arturbosch.detekt.rules.naming.VariableNaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These imports don't need to be here.
|
||
import io.gitlab.arturbosch.detekt.rules.naming.NamingRules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and some other files too.
|
||
import io.gitlab.arturbosch.detekt.rules.naming.NamingRules | ||
import io.gitlab.arturbosch.detekt.rules.naming.PackageNaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is UnusedImports
not picking these up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I updated the PR. I guess UnusedImports
is not picking them up because something named PackageNaming
is actually used in this file. But since we don't have type resolution we can't verify that these are actually different so these are not reported.
|
||
import io.gitlab.arturbosch.detekt.rules.naming.MatchingDeclarationName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, ClassNamingSpec.kt
and EnumNamingSpec.kt
too.
08d4818
to
3fbd37a
Compare
Merged manually. |
This PR adds the naming ruleset as discussed in #689
After #689 is merged I'll re-generate the documentation and config of this PR to get it sorted correctly.
The naming ruleset contains:
MatchingDeclarationName
MemberNameEqualsClassName