-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Gradle functional tests by Gradle version #7036
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7036 +/- ##
=========================================
Coverage 83.79% 83.79%
Complexity 3941 3941
=========================================
Files 579 579
Lines 12119 12119
Branches 2511 2511
=========================================
Hits 10155 10155
Misses 710 710
Partials 1254 1254 ☔ View full report in Codecov by Sentry. |
...src/functionalTestMinSupportedGradle/kotlin/io/gitlab/arturbosch/detekt/GradleVersionSpec.kt
Fixed
Show fixed
Hide fixed
...src/functionalTestMinSupportedGradle/kotlin/io/gitlab/arturbosch/detekt/GradleVersionSpec.kt
Fixed
Show fixed
Hide fixed
@@ -3,10 +3,12 @@ package io.gitlab.arturbosch.detekt | |||
import io.gitlab.arturbosch.detekt.testkit.DslTestBuilder | |||
import org.assertj.core.api.Assertions.assertThat | |||
import org.gradle.testkit.runner.TaskOutcome | |||
import org.gradle.testkit.runner.internal.PluginUnderTestMetadataReading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like using an internal method here but if it's removed/changed in Gradle we can easily copy/paste into our project, it's quite self-contained.
Resolved issues found while implementing #6489, #6913 and #7025