Add KotlinBuiltIns extensions #7376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would ideally be provided by org.jetbrains.kotlin.types.typeUtil which has wrappers for most KotlinBuiltIns functions. Those that are missing that would be generally useful can be added to detekt's TypeUtils.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7376 +/- ##
============================================
+ Coverage 84.50% 84.51% +0.01%
- Complexity 4168 4169 +1
============================================
Files 573 573
Lines 11897 11899 +2
Branches 2461 2461
============================================
+ Hits 10053 10056 +3
Misses 591 591
+ Partials 1253 1252 -1 ☔ View full report in Codecov by Sentry. |
BraisGabin
reviewed
Jun 16, 2024
| @@ -21,6 +22,10 @@ fun KotlinType.fqNameOrNull(): FqName? { | |||
| return TypeUtils.getClassDescriptor(this)?.fqNameOrNull() | |||
| } | |||
|
|
|||
| fun KotlinType?.isString(): Boolean = KotlinBuiltIns.isString(this) | |||
There was a problem hiding this comment.
In general I'm not a big fan of extensions over nullable. Should null.isString() be true or false? To me that's something that the caller should decide.
+1 to this 👍 |
cortinico
approved these changes
Jun 20, 2024
schalkms
approved these changes
Jul 3, 2024
|
@3flex this can be rebase and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would ideally be provided by org.jetbrains.kotlin.types.typeUtil which has wrappers for most KotlinBuiltIns functions. Those that are missing that would be generally useful can be added to detekt's TypeUtils.