Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to work on maven multi-module project #991

Merged

Conversation

duck8823
Copy link
Contributor

I tried using detekt-maven-plugin is introduced by README in this repository.
But, unfortunately, it didn't work in my multi-module project.

I made a sample here.
The detekt task success first module, but second module occurred error Can only specify option -i once..

I found that jcommander instance is defined as global variable.
Because the jcommander instance is used multiple times in multi-module project, argument parse error occur!

In this PR, I suggest that jcommander instance define as local variable.

@arturbosch
Copy link
Member

Hey good catch! This is a leftover from a refactoring, thanks for contributin!

@arturbosch arturbosch merged commit 75f2184 into detekt:master Jul 13, 2018
@arturbosch arturbosch added this to the RC8 milestone Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants